search

Firehed / multistage-docker-build-action

Github Action for optimized multi-stage docker builds
10 stars 3 forks source link

Action may continue even if push fails #34

Closed Firehed closed 1 year ago

Firehed commented 1 year ago

https://github.com/Firehed/multistage-docker-build-action/actions/runs/3504039849/jobs/6015269075

Screen Shot 2022-11-29 at 10 20 44 AM

Noticed this while trying to diagnose build failures in #32. It doesn't seem to be consistent; I've seen push failures correctly cause this action to fail before.

Firehed commented 1 year ago

This is not limited to push failures - any step in the build failing appears to replicate the issue:

Screen Shot 2022-12-13 at 3 17 48 PM
Firehed commented 1 year ago

During working on #35, it looks like this may have been a regression introduced in #29: https://github.com/Firehed/multistage-docker-build-action/pull/29/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R22-R24