search

Firehed / u2f-php

An implementation of the FIDO U2F server protocol in PHP
MIT License
73 stars 9 forks source link

Interfaces for Registration and Request (and SignRequest…)? #4

Closed matthewslouismarie closed 3 years ago

matthewslouismarie commented 6 years ago

Just a potential improvement that could be made to the library to improve interoperability. I'm working on a library that uses Firehed U2F, but because I only want to expose interfaces I have to convert Registration, SignRequest, etc. objects into implementations of interfaces (e.g. IU2fRegistartion, etc.)

I believe it would be better if there were some standard interfaces that U2F objects could implement.

Firehed commented 6 years ago

This is a great idea, and I will look into setting it up soon (or review a pull request, if you’d like to take that approach)

matthewslouismarie commented 6 years ago

I could do that, yes! :)

Firehed commented 6 years ago

Thanks! In case you haven't seen it, it's probably worth reading this since there's probably some small amount of overlap.