Firehed / webauthn-php

Web Authentication for PHP
MIT License
14 stars 1 forks source link

Improve logic matching key type to curve #51

Open Firehed opened 10 months ago

Firehed commented 10 months ago

This improves adherence to the callout in §5.8.5. Note that the library still supports only ES256 with P-256. If a future version of the library supports additional key types and curves, this will be a more robust matching approach.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f89a112) 82.10% compared to head (0da3e54) 82.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ============================================ + Coverage 82.10% 82.31% +0.20% Complexity 199 199 ============================================ Files 24 24 Lines 598 605 +7 ============================================ + Hits 491 498 +7 Misses 107 107 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.