search

Firehed / webauthn-php

Web Authentication for PHP
MIT License
14 stars 2 forks source link

Parse transports and pass them through to the credential #55

Closed Firehed closed 1 year ago

Firehed commented 1 year ago

Pulled out of #53 - it's desirable to store the transports alongside the credential in order to present future UI hints (note: it's not trusted data). Since that PR was getting pretty large, that aspect is being split out for readability.

Note: this maintains complete backwards compatibility with the original wire format, but does add a new recommendation to start passing the transports through.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (66d9dfc) 81.03% compared to head (af4f7e9) 81.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ============================================ + Coverage 81.03% 81.30% +0.27% - Complexity 208 210 +2 ============================================ Files 25 25 Lines 617 626 +9 ============================================ + Hits 500 509 +9 Misses 117 117 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.