search

Firehed / webauthn-php

Web Authentication for PHP
MIT License
14 stars 2 forks source link

Add limited support for RS256 #79

Closed Firehed closed 8 months ago

Firehed commented 8 months ago

Adds support for RSA COSE key parsing and subsequent reformatting to PEM. For the most part, everything downstream Just Works since it implements the same PublicKeyInterface as EllipticCurve

In theory, this should work in all (legal) assertion paths. I'm less sure about attestation, so I'm indicating only partial support in the README. As the remaining attestation formats get supported, this should become extremely clear. Most formats don't really look at the public key in favor of the bundled certificate chain.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.30%. Comparing base (69fdcd3) to head (f33d4bf).

Files Patch % Lines
src/PublicKey/RSA.php 96.55% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ============================================ + Coverage 78.51% 81.30% +2.78% - Complexity 304 307 +3 ============================================ Files 32 33 +1 Lines 954 984 +30 ============================================ + Hits 749 800 +51 + Misses 205 184 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.