search

FirehoseCommunity / DEFCON

6 stars 4 forks source link

Use SuckerPunch gem instead of Sidekiq and Redis (annnnnd upgrade to Rails 4.2) #114

Closed jeffgerlach closed 8 years ago

jeffgerlach commented 8 years ago

So....this one ended up being a bit more involved than I was expecting! I couldn't quite figure out how to get things playing nicely with the sucker_punch gem in Rails 4.0, so I tried upgrading the app to Rails 4.2, and voila, the magic happened (and surprisingly only 1 test failed on the update which was a quick fix). The actual async mail implementation in 4.2 was very clear and easy, and should allow us to run in production without a dedicated worker dyno on Heroku. While I'm guessing we may want to have a separate issue to perform the 4.2 upgrade, I figure I'll submit this as a PR for now since it does appear to work as intended.

kenmazaika commented 8 years ago

Solid work, @jeffgerlach :+1:.

For everyone else. On rails 4.2, if you're using vagrant you'll need to run the following command to start the rails server.

rails server -b 0.0.0.0

Otherwise it will seem like the server isn't starting.