Added db field for github_handle to Users table and edited associated views

FirehoseCommunity / DEFCON

6 stars 4 forks source link

Added db field for github_handle to Users table and edited associated views #132

Closed NKHolton closed 8 years ago

NKHolton commented 8 years ago

This is for Issue #107. Made edits to the schema, several views and Application and Users controller. I do not think I've done all of the necessary changes for this yet though. Was hoping to talk about it more at tonight's meeting.

kenmazaika commented 8 years ago

The code you have here looks good to me. If you didn't say you don't think it's complete, I would've merged it. Looking forward to talking about this on the call this evening.

NKHolton commented 8 years ago

Great! My outstanding questions (that again we can discuss later) are:

The code I inserted into the Application Controller- should it have been handled in the User Controller instead? (the 'before_filter' and 'def configure_sanitized_params..')
Is there anything to specify that the github_handle field is not required during registration? Or do we want it to be?
In Views -> Users -> edit.html.haml : added the 'f.input :github_handle' under Name. Does it also need 'autofocus: true' on that line of code? (Don't really understand what autofocus does to an input)
Are there other views that need editing? Such as the Admin -> Users -> Invitations -> Show and Edit?

Thanks!

kenmazaika commented 8 years ago

Perfect. Putting it in application_controller.rb is the correct place to go.

Fields aren't required by default. If we want to make it required, we'd need to add a validation:

validates :github_handle, :presence => true

Autofocus makes the cursor of the user be in that field blinking when the page loads. Only one form field can have autofocus and usually it's the form element nearest to the top.