FirehoseCommunity / DEFCON

6 stars 4 forks source link

The topnav should have a pop-down menu #87

Closed kenmazaika closed 8 years ago

kenmazaika commented 8 years ago

Like in the wireframes.

ceceliahavens commented 8 years ago

Could you please clarify for me? I have just looked at the wireframes but I am not clear on what we are looking for here. Thanks!

kenmazaika commented 8 years ago

The wireframes indicate that on the top right there should be a dropdown menu like here:

https://getbootstrap.com/examples/navbar/

amarkpark commented 8 years ago

@ceceliahavens You can look at (or steal) the dropdown that I have as the Admin Menu... https://github.com/FirehoseCommunity/DEFCON/blob/master/app/views/layouts/_adminmenu.html.haml Right now there is only one functional link in there, it was just something I added for grouping together admin stuff but we can actually move that whole menu into the main navbar and change out current placeholder links for live nav links and change it so the admin stuff is just hidden by logic in one of the separator sections maybe...? I made the admin menu partial before I thought too closely about the wireframe layout. The admin link(s) can be hidden instead of having a hidden partial...?

ceceliahavens commented 8 years ago

Thanks @amarkpark I already implemented one before I read your offer! @kenmazaika, what is supposed to be included in the drop down? That is the part I was unclear on. I've committed to the dropdown branch the skeletal structure of a dropdown, which just took me a minute to do, but I am not sure by the wireframes what the dropdown is supposed to include. I'll use the dropdown branch as the place holder until I get a little clarification. thanks!

kenmazaika commented 8 years ago

I believe the wireframes I have include the items that it should have. Take a look there. I think it has "Sign in" and "Sign out" in a popup along with the user name.

ceceliahavens commented 8 years ago

Thanks, those were floating off to the side and it said "pop up" so i wasn't sure if that was something else we were after. I'll get it taken care of straight away.

kenmazaika commented 8 years ago

Thanks, @ceceliahavens!

kenmazaika commented 8 years ago

Implemented!