Fix (core): Flight Paths on Faction Changes - Githubissues

FirelandsProject / firelands-cata

This is an open source project, from the emulator version 4.3.4. Log in to the discord for more information: https://discord.com/invite/GZ5rsxumxN

GNU Affero General Public License v3.0

55 stars 45 forks source link

Fix (core): Flight Paths on Faction Changes #161

Closed acidmanifesto closed 1 year ago

acidmanifesto commented 1 year ago

Changes proposed

Level Appropiate Flight Points on Faction Change, currently all flight points open up for players for the factions they swap to regardless of level. We used the lfg system and create a LFG Zone to handle per level

Issues addressed

Closes source notes in characterhandler.cpp

Tests performed

Builds and runs

How to Test the Changes:

Perform a .character changefaction on any mid or low level character just so you dont see all points as if it was max character.
observe flight points that are unlocked via flight mangers
Fine tuned the horde coordinates on faction swap as the old location was clippinged the player under the auction house.

horde level 21

alliance level 21

Known issues and TODO list

[ ]
[ ]

Thank you for collaborating with the project.
For an efficient working methodology.
It is obvious to make long pull request, unless it is necessary.
A short pull request would be easy to test and approve.

acidmanifesto commented 1 year ago

Looks preerty good for me

Lets avoid merging for the moment. I did a discussion with Meltie and we see a possible opportunity with this pr we want to explore.

seobryn commented 1 year ago

Hello, @acidmanifesto @Meltie2013 do you think that PR needs more things to do or improve?

Meltie2013 commented 1 year ago

@seobryn Don't think this PR was ready to be merged just yet. Please avoid merging PRs without conformation first.