Implement (core): Despawn on Summoner Death Flag - Githubissues

FirelandsProject / firelands-cata

This is an open source project, from the emulator version 4.3.4. Log in to the discord for more information: https://discord.com/invite/GZ5rsxumxN

GNU Affero General Public License v3.0

55 stars 45 forks source link

Implement (core): Despawn on Summoner Death Flag #176

Closed acidmanifesto closed 1 year ago

acidmanifesto commented 1 year ago

Pets\Guardians\Totems\Temp Summons are not suppose to despawn when their summoner is killed unless they have the SUMMON_PROP_FLAG_DESPAWN_ON_SUMMONER_DEATH flag. This deals with the SUMMON_PROP_FLAG_DESPAWN_ON_SUMMONER_DEATH Flag not being implemented or scripted. We script and label this flag to ensure it is works in core.

Changes proposed

label SUMMON_PROP_FLAG_DESPAWN_ON_SUMMONER_DEATH summon properly
script SUMMON_PROP_FLAG_DESPAWN_ON_SUMMONER_DEATH flag

Issues addressed

Closes None

SOURCE:

Tests performed

type in .cheat god
.go c 303878
kill the razorman hunter, observe its pet is still present and did not auto despawn.

Thank you for collaborating with the project.
For an efficient working methodology.
It is obvious to make long pull request, unless it is necessary.
A short pull request would be easy to test and approve.

acidmanifesto commented 1 year ago

Got some sort of load order issue i will address later.