search

FirelandsProject / firelands-cata

This is an open source project, from the emulator version 4.3.4. Log in to the discord for more information: https://discord.com/invite/GZ5rsxumxN
GNU Affero General Public License v3.0
55 stars 45 forks source link

Innkeeper Belm Does Not Function as Innkeeper #199

Closed Steveboi90 closed 2 months ago

Steveboi90 commented 2 months ago

Current Behaviour

Despite having the npcflag set to 65536 (Innkeeper), which should allow the NPC to function as an Innkeeper and offer the option to set a hearthstone, Innkeeper Belm does not provide this functionality. The option to set the hearthstone is missing when interacting with the NPC.

Details:

NPC Entry ID: 1247

NPC Name: Innkeeper Belm

Flag Set: 65536 (Innkeeper)

Issue: The NPC does not display the option to set the hearthstone, despite the appropriate flag being set.

Expected Blizzlike Behaviour

Innkeeper Belm should provide the option to set a hearthstone, consistent with other Innkeepers in the game.

Source

No response

Steps to reproduce the problem

Log in to the game.

Locate Innkeeper Belm (Entry ID 1247).

Interact with the NPC.

Observe that the option to set the hearthstone is missing.

Extra Notes

No response

FC rev. hash/commit

FC>Firelands rev. https://github.com/FirelandsProject/firelands-cata/commit/f1b6fc5b51e9f0507dad70d8072ab59bb72f3dad 2024-07-31 23:45:08 +0000 (master branch) (Unix, RelWithDebInfo, Static) Using SSL version: OpenSSL 3.0.2 15 Mar 2022 (library: OpenSSL 3.0.2 15 Mar 2022) Using Boost version: 1.74.0 Using MySQL version: 80039 Using CMake version: 3.22.1 Compiled on: Linux 5.15.0-117-generic Automatic database updates are enabled for the following databases: Auth, Characters, World Worldserver listening connections on port 8085 Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1 MMAPs status: Enabled maps directory located in /home/firelands/server/bin/data/maps. Total size: 409779433 bytes vmaps directory located in /home/firelands/server/bin/data/vmaps. Total size: 881241574 bytes mmaps directory located in /home/firelands/server/bin/data/mmaps. Total size: 2942694492 bytes Using enUS DBC Locale as default. All available DBC locales: enUS none Using World DB: FDB 434.22012

Operating system

Ubuntu 22.04

Custom changes or Modules

SoloCraft

Steveboi90 commented 2 months ago

Solution: Updating the gossip_menu_id for Innkeeper Belm to 1291 resolves the issue. The following SQL query fixes the problem:

UPDATE creature_template SET gossip_menu_id = 1291 WHERE entry = 1247;

Steps Taken:

Logged into the database. Executed the above SQL query. Verified that the option to set a hearthstone is now available when speaking to Innkeeper Belm. Additional Notes: This fix ensures that Innkeeper Belm displays the correct innkeeper options, allowing players to set their hearthstone inside the Thunderbrew Distillery.