FirelyTeam / firely-cql-sdk

BSD 3-Clause "New" or "Revised" License
30 stars 18 forks source link

2.0/290 Remove trailing whitespace, dead code. Add tests to check it. #356

Closed baseTwo closed 3 months ago

baseTwo commented 3 months ago

ℹ️Work for #290

Failing test looks like this

The following files have lines with trailing whitespace:
\Demo\CLI\LibraryRunner.cs
   6:        private readonly StreamWriter? _writer;     <eol>
   6:        <eol>
   6:                    <eol>
   6:        #region Writing Output     <eol>
   6:    }   <eol>
\Cql\Cql.Compiler\Expressions\NullConditionalMemberExpression.cs
   6:            // Nothing <eol>
\Demo\CLI\Helpers\ResourceHelper.cs
   6:        };     <eol>
   6:            parametersConverted.Add(parameter.Name, converted!);         <eol>
baseTwo commented 3 months ago

When running tests on the build pipeline, the tests are isolated from the source code, so it is not possible to get access to the solution dir from the test runner agent. The PR is therefore closed