FirelyTeam / firely-cql-sdk

BSD 3-Clause "New" or "Revised" License
28 stars 16 forks source link

OverloadedFunctionDefintion.Add does not guard against ambiguous overloads #439

Open ewoutkramer opened 1 month ago

ewoutkramer commented 1 month ago

When an OverloadedFunctionDefinition is created using the Combine factory methods, the CanCombine function is called to check that none of the overloads is ambiguous by having exactly the same signature. However, once constructed, one can use the Add method to add additional overloads, for which these checks are not done.

We should fix the Add function so it does check for uniqueness.