Fix Integration test - System.ArgumentException: 'Cannot generate a hash code for ValueTuple`3 Arg_ParamName_Name' - Githubissues

FirelyTeam / firely-cql-sdk

BSD 3-Clause "New" or "Revised" License

30 stars 17 forks source link

Fix Integration test - System.ArgumentException: 'Cannot generate a hash code for ValueTuple`3 Arg_ParamName_Name' #613

Open baseTwo opened 1 month ago

baseTwo commented 1 month ago

Error

The Integration Test running is failing with the following exception:

System.ArgumentException
  HResult=0x80070057
  Message=Cannot generate a hash code for ValueTuple`3 Arg_ParamName_Name
  Source=Hl7.Cql.Comparers
  StackTrace:
   at Hl7.Cql.Comparers.CqlComparers.GetHashCode(Object x) in C:\Dev\firely-cql-sdk\Cql\Cql.Comparers\CqlComparers.cs:line 321

at

Measures.CMS.dll!UrinarySymptomScoreChangeAfterBenignProstaticHyperplasiaFHIR_1_3_000.Urinary_Symptom_Score_Assessment(Hl7.Cql.Runtime.CqlContext context) Line 707
    at C:\Dev\firely-cql-sdk\Demo\Measures.CMS\CSharp\UrinarySymptomScoreChangeAfterBenignProstaticHyperplasiaFHIR-1.3.000.g.cs(707)

while running this test

UrinarySymptomScoreChangeAfterBenignProstaticHyperplasiaFHIR.Population_FromResource(testCaseId: "051c5977-9f2c-4e8b-8e02-ac3ec0c718d6")

Background

Tuples emitted to C# have recently changed from being derived from TupleBaseType to just value tuples (ValueTuple<,,,...> at runtime).

Solution

The CqlComparer must be updated to support value tuples
Add unit tests
TupleBaseType is part of the Cql.Primitives project. It is no longer used at runtime, consider making this internal. It is only used to generate the expression LINQ tree as a temporary placeholder until C# generates value tuples.