FirelyTeam / firely-cql-sdk

BSD 3-Clause "New" or "Revised" License
30 stars 17 forks source link

ELM produced by Java tooling contains error annotations #93

Open ewoutkramer opened 1 year ago

ewoutkramer commented 1 year ago

I have added a check in the ExpressionBuilder so it refuses to build ELM that has error annotations. This makes many of our unit tests fail, since the generated ELM by the java tooling contains errors.

Is this known?

I will now try to add a setting to enable/disable compiling elm with errors.

EvanMachusak commented 1 year ago

Are they errors or warnings?

I assume you mean the HL7 unit tests?

ewoutkramer commented 11 months ago

I assume you mean the HL7 unit tests?

No, ExpressionBuilderTests, specifically

E.g.:

{
      "type" : "CqlToElmError",
      "librarySystem" : "C:\\Code\\Ncqa.HT\\Hedis2023\\Cql\\input\\libs\\test\\Aggregates-1.0.0.cql",
      "libraryId" : "Aggregates-1.0.0",
      "startLine" : 1,
      "startChar" : 0,
      "endLine" : 1,
      "endChar" : 0,
      "message" : "token recognition error at: '?'",
      "errorType" : "syntax",
      "errorSeverity" : "error"
},