search

FirelyTeam / firely-net-sdk

The official Firely .NET SDK for HL7 FHIR
Other
829 stars 345 forks source link

changed type of FhirEvalContext.TerminologyService #2909

Closed Kasdejong closed 1 month ago

Kasdejong commented 1 month ago

Description

Changed the type of FhirEvaluationContext.TerminologyService to ICodeValidationTerminologyService

Related issues

Closes #2590

alexzautke commented 1 month ago

Haha. See, I had the same argument last year.

ewoutkramer commented 1 month ago

Yeah, and I think you are right. We should probably pick an interface that has memberOf() as well. Of course, it's just a matter of time before people want more, though. But that does not mean all termservices also implement it. That's the beauty of making it explicit.

alexzautke commented 1 month ago

Would it make sense to add a way for the ITerminologyService to report which methods are supported by the service?

Kasdejong commented 1 month ago

Both ValueSetValidateCode (memberOf) and Subsumes are defined in ICodeValidationTerminologyService. It is just operations like Closure and Expand which are not in this interface.