search

FirelyTeam / firely-net-sdk

The official Firely .NET SDK for HL7 FHIR
Other
830 stars 345 forks source link

Fix wrong attachment url datatype in PocoSummaryProvider #2952

Closed mmsmits closed 4 weeks ago

mmsmits commented 1 month ago

Description

Changed datatype of attachment.Url from Url to Uri in STU3.

Related issues

fixes: https://github.com/FirelyTeam/firely-validator-api/issues/383

Testing

Added new roundtrip test of comparing the SDSummaryProvider vs PocoSummaryProvider for all datatypes.

mmsmits commented 4 weeks ago

It could break our code, that's why it's a breaking change, but @ewoutkramer and I discussed that we consider this such a minor "breaking bug" that we take the chance. But you are right. I will run the validation tests before merging, just to be sure.

Kasdejong commented 4 weeks ago

I saw the discussion in FS, so I'm aware that it will indeed be necessary to do here and not in 6.0, I was just wondering if we could get a grasp on how breaking it really is :)

mmsmits commented 4 weeks ago

No changes in the validator unit tests because of this PR. I'm merging this.