This PR makes sure that all FHIR properties on the POCO's are now FHIR types, and no longer .NET types (which Element.ElementId and Extension.Url were). This was, interestingly, not a breaking change to the POCOs, since the only thing I needed to do was to add xxxxElement properties, turning the original primitive properties into the usual "helper" properties. As such, there is compile-time compatibility.
What did change was the fact that GetElementPairs() now no longer returns .NET primitives, but always either a Base subclass or a List of Base. Also, GetElementPairs() will not list the value property of primitives anymore, as from now on the FHIR Primitives are considered to be the leaves in the tree (just like in ITypedElement), and one can easily access the Value property of the Primitive.
These last two changes required me to update the POCO serializers/deserializers and the PocoBuilders. Also, quite a few unit tests (that tested the old behaviour) had to be updated.
Breaking changes
There is a slight breaking change (which we don't need to document), in that one of the errors will not be thrown anymore, as there are no longer Poco properties that are just .NET primitives. I removed that error from the public surface, since it cannot be raised anymore.
This PR makes sure that all FHIR properties on the POCO's are now FHIR types, and no longer .NET types (which Element.ElementId and Extension.Url were). This was, interestingly, not a breaking change to the POCOs, since the only thing I needed to do was to add
xxxxElementproperties, turning the original primitive properties into the usual "helper" properties. As such, there is compile-time compatibility.What did change was the fact that
GetElementPairs()now no longer returns .NET primitives, but always either a Base subclass or a List of Base. Also,GetElementPairs()will not list thevalueproperty of primitives anymore, as from now on the FHIR Primitives are considered to be the leaves in the tree (just like in ITypedElement), and one can easily access theValueproperty of the Primitive.These last two changes required me to update the POCO serializers/deserializers and the PocoBuilders. Also, quite a few unit tests (that tested the old behaviour) had to be updated.
Breaking changes
There is a slight breaking change (which we don't need to document), in that one of the errors will not be thrown anymore, as there are no longer Poco properties that are just .NET primitives. I removed that error from the public surface, since it cannot be raised anymore.
Fixes #2963.
⚠️ Also review and pull https://github.com/FirelyTeam/fhir-codegen/pull/46, which produces the necessary changes to the generated code included in this PR.