search

FirelyTeam / firely-net-sdk

The official Firely .NET SDK for HL7 FHIR
Other
829 stars 345 forks source link

Hl7.Fhir.Support net40 support #363

Closed u8621011 closed 7 years ago

u8621011 commented 7 years ago

Is Hl7.Fhir.Support possible to support net40 platform?

We saw that Hl7.Fhir.DSTU2 an Hl7.FhirPath have net40 platform but Hl7.Fhir.Support not, is that jsut a missing piece?

ewoutkramer commented 7 years ago

Hi Ted,

We have dropped support for net40. Hl7.fhir.support is built on dotnet standard - and we have moved our whole codebase to dotnet standard, which does not support net4.0.

That being said, we've supported net 4.0 for a long time, so it should still be possible to compile at least .NET API Core for net4 (not .NET API Specification, since it needs zip support).

lstratman commented 7 years ago

I actually forked and added support for the net40 target to Hl7.Fhir.STU3, Hl7.Fhir.Support, and Hl7.FhirPath with a minimum of fuss. The vast majority of the divergence between the two targets was around reflection and things being moved from Type to TypeInfo, so once I implemented a TypeInfo polyfill for net40 with the required methods and properties, it worked great and the maintenance going forward should be pretty minimal.

I can send a PR if you would like.

ewoutkramer commented 7 years ago

Yes, please!

u8621011 commented 7 years ago

Great Job and thanks for your sharing~ @lstratman

ewoutkramer commented 7 years ago

I will pull the PR.

brianpos commented 7 years ago

Yes, thanks for the contribution.