search

FirelyTeam / firely-net-sdk

The official Firely .NET SDK for HL7 FHIR
Other
829 stars 345 forks source link

Add (x)path location information to validation errors #7

Closed ewoutkramer closed 7 years ago

brianpos commented 7 years ago

This is more likely fhirpath locations now...

brianpos commented 7 years ago

I believe this is now ok as you've done the fhirpath location right?

ewoutkramer commented 7 years ago

Well, this is about the dotnet attributes, not the profile validator. The dotnet validation attributes have no knowledge of the (fhirpath/xpath) location, since all they know about is the POCO's, and poco instances (and elements in the instance) don't know anything about path.

Have no clue how to do this....

brianpos commented 7 years ago

Do we even want need that stuff now? Should we ditch it? If we were to keep it, i can see how we'd implement the fhirpath given a property. (or at least have a fair idea, and could give it a whirl)

ewoutkramer commented 7 years ago

I don't know whether we need it now we have profile validation, maybe @cknaap can comment. The validation attributes itself are useful - if you have a control bound to them, they will show the error message (Forge uses this), just don't know whether we still need the path.

ewoutkramer commented 7 years ago

No one reacts, closing this issue.