search

Firesphere / silverstripe-bootstrapmfa

Bootstrap your MultiFactor with backup codes and a ready-to-go second-factor authentication
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Make MFAAuthenticator Abstract #50

Open ScopeyNZ opened 5 years ago

ScopeyNZ commented 5 years ago

Currently the MFAAuthenticator behaves like an abstract class but isn't an abstract. There's a comment in the leading docblock:

https://github.com/Firesphere/silverstripe-bootstrapmfa/blob/390eae6582cecb5c2bbd51256b76cff5e1898d6b/src/Authenticators/BootstrapMFAAuthenticator.php#L17

It should be abstract but we'll need to identify why it "can't".