search

Firesphere / silverstripe-yubiauth

Yubikey Authentication for SilverStripe CMS
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Marco/master #13

Closed Firesphere closed 6 years ago

Firesphere commented 6 years ago

Multiple code-improvements on top of @ssmarco's PR.

codecov-io commented 6 years ago

Codecov Report

Merging #13 into master will increase coverage by 18.69%. The diff coverage is 72.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #13       +/-   ##
============================================
+ Coverage      63.2%   81.9%   +18.69%     
- Complexity       59      70       +11     
============================================
  Files             6       6               
  Lines           212     210        -2     
============================================
+ Hits            134     172       +38     
+ Misses           78      38       -40
Impacted Files Coverage Δ Complexity Δ
src/Forms/YubikeyLoginForm.php 100% <ø> (+44.44%) 4 <0> (ø) :arrow_down:
src/Helpers/QwertyConvertor.php 94.44% <ø> (-0.3%) 7 <0> (ø)
src/Forms/YubikeyForm.php 100% <100%> (+16%) 5 <0> (ø) :arrow_down:
src/Handlers/YubikeyLoginHandler.php 100% <100%> (+39.39%) 12 <2> (+3) :arrow_up:
src/providers/YubikeyAuthProvider.php 54.54% <41.17%> (ø) 17 <17> (?)
src/Authenticators/YubikeyMemberAuthenticator.php 83.09% <82.35%> (+15.45%) 25 <11> (+5) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc36662...38485aa. Read the comment docs.

Firesphere commented 6 years ago

Accepting this PR with work from @ssmarco , More improvements might be done, but I think with 90+ coverage and manual testing works (multiple times and tries), we'll see if nee bugs pop up.