Firm-Collective / ai-journal

This is the AI Journal app / module

0 stars 1 forks source link

Added android app link that opens the app from the email confirmation #40

Closed Lyton505 closed 1 week ago

Lyton505 commented 1 week ago

Describe your changes

Implemented opening the app from the confirmation URL sent by supabase

Issue ticket number and link

20

Screenshots / Video

https://github.com/Firm-Collective/ai-journal/assets/65817176/f5a4a53c-524d-49dd-9555-6e9720d848ea

Checklist

[x] I have performed a self-review of my code
[x] I have used npx expo-doctor to review any dependency issues.
[x] I have pulled and merged any recent changes from the main branch (no merge conflicts)
[x] I have tested thoroughly any edge cases that might break the application
[x] I have deleted any console.log statements and useless comments

dave-cao commented 1 week ago

I am getting a secureStore error saying it's over 2048 bytes.

This only occurs for users who have confirmed their email. My test@email.com account which didn't confirm the email didn't have this error. Not sure if we should look for an alternative storage method or figure out a way to reduce the size.

dave-cao commented 1 week ago

I am getting a secureStore error saying it's over 2048 bytes.

This only occurs for users who have confirmed their email. My test@email.com account which didn't confirm the email didn't have this error. Not sure if we should look for an alternative storage method or figure out a way to reduce the size.

I updated the secureStorage to compress the data before storing. I will push the changes now. If you can test it to see if it still works on your end, I will merge the changes :)

Lyton505 commented 1 week ago

I hadn't tested a non existent email. Good catch. Seems to work on my end now

dave-cao commented 1 week ago

I hadn't tested a non existent email. Good catch. Seems to work on my end now

Sounds good, I'll merge it now!