NetworkCollider: Incorrect OnEnter invocation during reconcilliation replay.

FirstGearGames / FishNet

FishNet: Unity Networking Evolved.

Other

1.39k stars 149 forks source link

NetworkCollider: Incorrect OnEnter invocation during reconcilliation replay. #659

Closed aaronkwan closed 4 months ago

aaronkwan commented 7 months ago

General Unity version: 2022.3.10f Fish-Networking version: 4.2.2R Discord link: https://discord.com/channels/424284635074134018/1234272046641319946/1234272046641319946

Description

OnEnter sometimes invoked when OnStay should be instead. Occurs during the first playback of the reconciliation cycle.

Replication Steps to reproduce the behavior:

see discord link.

Expected behavior

normal health prediction and reconciliation

Actual behavior

janky health prediction and reconciliation (double damages)

Screenshots

see discord link.

FirstGearGames commented 6 months ago

Edited/removed.

FirstGearGames commented 6 months ago

I thought I was able to replicate by bumping the latency up significantly but I realized shortly after it's because the latency was exceeding the buffer on the NetworkTrigger. When the buffer is exceeded old states are dropped, thus the Entered state has been dropped.

Increasing the buffer beyond latency resolves the issue. If you are experiencing this while your latency is well below the History Duration please ping me in your thread so we can take a look together.

FirstGearGames commented 6 months ago

This issue is staying open until it can be confirmed as existing, or reasonably not existing. At this time there's not enough information to replicate the issue but it's still being worked on with a handful of individuals.

FirstGearGames commented 4 months ago

After testing and the efforts of many this issue is no longer reproducible on 4.3.5+.

If the problem still persist for you please reach me on Discord FirstGearGames linking this issue so it can be re-opened. Either way though, I'll definitely need a test project.