Referees 2018/configurable files

[idanstark42]

This is what we talked about. All is configurable via the configuration file or the configuration view (i think I did this correctly)

[rikkertkoppes]

In general it look pretty much ok, I have made some remarks here and there.

Apply a linter and a jsformatter to the code. There are a few styling issues:

• always add curlies to an if statement, even if it is just one line. This prevents unintended bugs
• remove trailing spaces
• add spaces around if statements
• use toString and parseInt / parseFloat rather than type constructors

What is the significance of the +6 suffix in the start track file name?

Lastly, add a bit of readme on how the track config works, which events are available

Overall, pretty nice work. This brings a lot more flexibility to the clock

[idanstark42]

Thank you for the review. I took your notes and made changes. The +6 on the file was there before... I just didn't remove it. All other things I hope I changed correctly

[rikkertkoppes]

Checked the pr, left a few comments. Basically, the branch does not work in this state. Lots of js errors, I have identified a few in the comments

[rikkertkoppes]

Ok, I got stuff kinda working now, but there is still a lot wrong with it. You might want to either start manual test scripts or automated tests for it all. The stuff added is rather complicated and a lot can go wrong with it.

The stuff I found thus far:

• from the code, it seems that a low more intricate stuff can be configured than is documented in the readme, specifically, apart from 'start', you can also stop, reset and pause tracks. This needs docs.
• it seems to also be possible to name tracks and use those as events. This is great, but undocumented
• events on time do not work. The problem is set the event is a number and in trigger the event is converted to string before being compared
• setting a track to something like 140 seconds before end does not work. From what I understand the whole before concept is broken as the listener is only added when the event end happens, which is too late
• when retriggering a start action for a track while it is still running, the track does not start again. For example, when I attach a track (e.g. track B) to the pause event, and quickly pause and unpause, I hear the sound only once. I think the running track should reset and play again.
• the above will surface the bug that events on seconds are emitted 100 times per second (on every tick).
• there is a lot of mixed tabs and spaces in all files, use spaces. I will add a .editorconfig file to make that process easier

[idanstark42]

I think I fixed everything... Tell me if not. About the third point (the pause and unpause). If you attached a track to the pause event, i.e. start on pause then it'll start when you pause, upause is a different event. But I think everything else is better now

[rikkertkoppes]

There is still a lot wrong here. These scenarios still don't work:

• setting a track to something like 140 seconds before end does not work. From what I understand the whole before concept is broken as the listener is only added when the event end happens, which is too late
• settings with percentages do not work as advertised (try e.g. 10%, which should start after 15sec on a 150s countdown. It starts at 10s)
• pause / unpause do not trigger any events