search

FirstLegoLeague / clock

Countdown clock for competition area
GNU General Public License v3.0
3 stars 15 forks source link

saving time on file, in case of a crash #44

Closed taltaub22 closed 5 years ago

taltaub22 commented 5 years ago
  1. Will fix
  2. Yes, my bad
taltaub22 commented 5 years ago

@idanstark42 Fixed. We discussed on the call to add 5 seconds so teams will not get affected by this error. If you think otherwise lets talk about it. @alanggreen @yosikarl

idanstark42 commented 5 years ago
  1. If we add this 5 seconds it's something that we shold tell the Tournament organizers. It could look worse then the crushes. The crush is the system missbehaving, but when adding a random 0-5 seconds to a match, it could make the competition unfare from the POV of the teams. @alanggreen your tohught on this point?
  2. You forgot to change the functions names in the manager
alanggreen commented 5 years ago

The idea of the extra time was this: If the clock crashes somewhere in the middle of the match, we resume the countdown when it comes up. But what happens if the clock crashes 1 sec before end? By the time clock restarts, the 2:30 is over there won't be an end sound. Solution: Up till x secs after 2:30, if the time file is still there when clock restarts, play the "end" before deleting time file.

idanstark42 commented 5 years ago

Please get @2roy999's opinion before you merge this