Cutting sounds to remove delay in sound

[2roy999]

I'm sorry I'm a bit lost, why would we want that the sounds will start half a second after the program start playing it. Even if there is a reason for delaying the sound (which I didn't understand yet), the right way is to put this dealy in the code. If you're creating a delay inside the sound files you are hiding a functionallity of your program.

[alanggreen]

I'm sorry I'm a bit lost, why would we want that the sounds will start half a second after the program start playing it.

There were numerous complaints at the time about the start of the sound being cut off. That is very noticeably, a half-second delay is not.

Even if there is a reason for delaying the sound (which I didn't understand yet), the right way is to put this delay in the code. If you're creating a delay inside the sound files you are hiding a functionality of your program.

At the time we didn't want to endanger the stability of the release. However, you are correct in what you say, especially because this patch i.e. technical debt, got forgotten. I think the delay should be removed as part of the solution for the mplayer startup delay.

[codecov-io]

Codecov Report

Merging #53 into master will increase coverage by 12.8%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   28.94%   41.74%   +12.8%     
==========================================
  Files          17       16       -1     
  Lines         425      412      -13     
  Branches        4        8       +4     
==========================================
+ Hits          123      172      +49     
+ Misses        302      239      -63     
- Partials        0        1       +1

Impacted Files	Coverage Δ
server/time-saver.js	0% <0%> (ø)	:arrow_up:
server/routes.js	0% <0%> (ø)	:arrow_up:
server/index.js	0% <0%> (ø)	:arrow_up:
server/manager.js	81.42% <100%> (+0.26%)	:arrow_up:
server/events-linker.js	100% <100%> (ø)	:arrow_up:
client/sound/index.jsx	100% <100%> (ø)
client/mhub-listener.js	35% <100%> (+35%)	:arrow_up:
client/settings/index.jsx	90% <87.5%> (+90%)	:arrow_up:
client/index.jsx
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8b7683...c09ff9c. Read the comment docs.