search

FirstLegoLeague / clock

Countdown clock for competition area
GNU General Public License v3.0
3 stars 15 forks source link

Upgraded UI package #57

Closed idanstark42 closed 5 years ago

2roy999 commented 5 years ago

Hi, I created a commit, changing the karma settings so we can see the passed and failed tests on appveyor (I fixed my single comment review on the way).

idanstark42 commented 5 years ago

The icon does not change when the window is opened, so some of the tests we're irrelevant.

codecov-io commented 5 years ago

Codecov Report

Merging #57 into master will decrease coverage by 0.62%. The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   41.74%   41.11%   -0.63%     
==========================================
  Files          16       16              
  Lines         412      411       -1     
  Branches        8        7       -1     
==========================================
- Hits          172      169       -3     
- Misses        239      240       +1     
- Partials        1        2       +1
Impacted Files Coverage Δ
client/app.jsx 0% <0%> (ø) :arrow_up:
client/controls/index.jsx 0% <0%> (ø) :arrow_up:
client/sound/index.jsx 100% <100%> (ø) :arrow_up:
client/settings/index.jsx 66.66% <100%> (-23.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b14ef0a...98a0db7. Read the comment docs.