search

FirstLegoLeague / clock

Countdown clock for competition area
GNU General Public License v3.0
3 stars 15 forks source link

Only play sound when not disabled #67

Closed alanggreen closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #67 into master will increase coverage by 0.24%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   38.88%   39.13%   +0.24%     
==========================================
  Files          15       15              
  Lines         414      414              
  Branches        9        9              
==========================================
+ Hits          161      162       +1     
+ Misses        250      248       -2     
- Partials        3        4       +1
Impacted Files Coverage Δ
client/sound/index.jsx 68.42% <100%> (+2.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3d7564...ae03210. Read the comment docs.

alanggreen commented 5 years ago

Maybe this bug means that there were some tests missing. @Idan Stark idanstark42@gmail.com what do you think?

On Thu, 10 Oct 2019 at 01:38, idanstark42 notifications@github.com wrote:

@idanstark42 approved this pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FirstLegoLeague/clock/pull/67?email_source=notifications&email_token=ABTRZDKVFSWJY5LYF5H5C23QNZMMPA5CNFSM4I6UIDCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHOZ34A#pullrequestreview-299736560, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTRZDKQIUV2VVRLDJ6BN3TQNZMMPANCNFSM4I6UIDCA .

-- Go green - keep it on the screen