search

FirstLegoLeague / display

FLL Team display screen
GNU General Public License v3.0
2 stars 4 forks source link

Hide logos now only hides local logos #42

Closed itamaroryan closed 4 years ago

alanggreen commented 5 years ago

So can this be merged yet?

On Mon, Oct 28, 2019, 9:50 PM idanstark42 notifications@github.com wrote:

@idanstark42 commented on this pull request.

In src/scss/components/rankings.scss https://github.com/FirstLegoLeague/display/pull/42#discussion_r339759631 :

@@ -3,7 +3,7 @@ }

rankings-row:not(.logo-striped) {

  • height: calc(100vh - 6rem);
  • height: calc(100vh - 6rem - 12.5%);

Oohhh, just got it. It's OK. my bad

In src/scss/components/rankings.scss https://github.com/FirstLegoLeague/display/pull/42#discussion_r339759892 :

@@ -3,7 +3,7 @@ }

rankings-row:not(.logo-striped) {

  • height: calc(100vh - 6rem);
  • height: calc(100vh - 6rem - 12.5%);

Ooohh just saw it. OK, my bad.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/FirstLegoLeague/display/pull/42?email_source=notifications&email_token=ABTRZDNHBZLFUXA2Z5DPPUTQQ47CFA5CNFSM4JFMR5Z2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJOVESA#discussion_r339759631, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTRZDK7GOITTNCUKZ5J573QQ47CFANCNFSM4JFMR5ZQ .

idanstark42 commented 4 years ago

No, not yet. There are still a few things to solve.

idanstark42 commented 4 years ago

Very good job! I'm merging this now :)