FirstLegoLeague / displaySystem

Set of display tools
https://firstlegoleague.github.io/displaySystem/
4 stars 7 forks source link

Referees 2018/table module #33

Closed idanstark42 closed 6 years ago

idanstark42 commented 7 years ago

Added table module, similar to the list module, but using the html table.

rikkertkoppes commented 6 years ago

It needs a few additions before I can merge this

rikkertkoppes commented 6 years ago

Added a few inline comments. As for styling, I guess I should have been a bit more clear, sorry about that

The idea is to have intrinsic styling in the modules themselves, these are the minimal styles needed for proper display, like margin, font-size, width, border-collapse, display, whitespace and overflow. Think of these as "default browser styles" for things like input elements or something

The extrinsic styling would go into the themes. These are the "user defined styles" like background, color and borders. Also text alignment for rtl users.

So, while the styling is a lot better inline with the overall red&blue style, it needs to be partly moved to these rednblue.css, default.css and fll.css and their rtl counterparts

rikkertkoppes commented 6 years ago

Thanks for all the work. It is a great addition to what we already have. In fact, a major improvement to the kinda cripple list module.

One thing I'd like to address in the near future is overall styling, to make it all a bit more fancy, but that is a separate thing.