do not rerender control window when controls are already there.

FirstLegoLeague / displaySystem

Set of display tools

4 stars 7 forks source link

Closed rikkertkoppes closed 6 years ago

rikkertkoppes commented 6 years ago

When pressing "C" a second time, the control window rendered a second set of controls. This has been fixed in this pr

closes #40

rikkertkoppes commented 6 years ago

That made me think. The adjustment probably broke the c -> f5 -> c sequence.

I need to check that and possibly rethink the approach

The window was repainted in the event of the page being refreshed as it binds everything to the new displaySystem instance.

By not repainting anymore, that is now probably broken.

Jheronymus commented 6 years ago

Just tested on normal branch and behavior is the same. Not broken by this change. I made a new issue for this subject: https://github.com/FirstLegoLeague/displaySystem/issues/45

poelstra commented 6 years ago

The remaining change (removing the confusing unused var) isn't really part of this PR, and is probably better fixed in #45.