Added sorting icons to the Ranking and the Scorekeeping pages

FirstLegoLeague / fllscoring

FLL Scoring app. See Demo:

http://firstlegoleague.github.io/fllscoring/

GNU General Public License v2.0

14 stars 19 forks source link

Added sorting icons to the Ranking and the Scorekeeping pages #269

Closed ThinkRedstone closed 6 years ago

ThinkRedstone commented 7 years ago

The index filter is currently broken, so I had to remove it from those two pages for the tables to even contain something besides the headers. When it's fixed the ng-repeat should be changed accordingly. As a result of that, sorting by index in scores.html does nothing.

Solves #249 , #241

Sorry, multiple forks are confusing.

poelstra commented 7 years ago

Index filter was fixed on master, please remove commit b55241c, and fixup the commit(s) that removed the index filter.

rikkertkoppes commented 7 years ago

There seem to be a lot more going on than just changing some icons. You might want to break it up into smaller commits, or squash a few, or update the pr title