search

FirstLegoLeague / fllscoring

FLL Scoring app. See Demo:
http://firstlegoleague.github.io/fllscoring/
GNU General Public License v2.0
14 stars 19 forks source link

Simplify ranking #286

Closed poelstra closed 7 years ago

poelstra commented 7 years ago

Part of #245 to prepare for making ranking computation independent of validation results.

The current ranking computation includes a special case where it does allow the first duplicate score to be included into rankings.

This was from before we had the possibility of having 'published' scores, where we didn't want a (most likely) scrutinized (checked) score to disappear due to a later (yet unchecked score) which contained a mistake.

We will switch to published scores only, which means this check is no longer necessary, and in fact makes the ranking computation independent of the scores validation.

Additionally, a small rename and removal of a redundant variable.

poelstra commented 7 years ago

Pushed a small fix, see commit message of last commit for reason of its change.

kmeesters commented 7 years ago

Checked and working (Windows 10, Node 8.5.0)