search

FirstLegoLeague / fllscoring

FLL Scoring app. See Demo:
http://firstlegoleague.github.io/fllscoring/
GNU General Public License v2.0
14 stars 19 forks source link

Ranking only published scores #288

Closed poelstra closed 7 years ago

poelstra commented 7 years ago

Part of #245.

This switches the ranking to include only published scores. Tests were updated accordingly.

Note: there are two 'strange' changes: removal of check for DuplicateScoreError and removal of haveFilter condition. Both of these are also already removed (and explained) in #286, so can be ignored for this PR. If #286 is merged first, I can fixup this PR to get rid of these two changes, if needed.

kmeesters commented 7 years ago

Just merged #286, have tested this and its working fine on my system (Win10, Node 8.5.0). Also verified the MHub messages (are only broadcasting the published scores). @poelstra: can you implement the fix for the 2 changes related to #286? Then can merge