FirstLegoLeague / fllscoring

FLL Scoring app. See Demo:
http://firstlegoleague.github.io/fllscoring/
GNU General Public License v2.0
14 stars 19 forks source link

Update node to allow async/await, fix corresponding build failures #290

Closed poelstra closed 6 years ago

poelstra commented 6 years ago

It appeared that our travis builds used yarn (instead of npm install), which caused subtly different versions of certain packages to be installed.

This in turn led to strange build failures after updating to Node 8.4 (or 8.6).

This PR removes yarn support and instead switches to package-lock.json (which is similar in nature to what yarn tried to solve).

It is a prerequisite for #289 to work.

poelstra commented 6 years ago

Added extra commit to fix coveralls reporting, too.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling cd2c610cb3d8ba1cd64e07c8d688be0ca3b8068c on allow_async_await into on master.

kmeesters commented 6 years ago

Tested and worked (Node 8.6.0) Firefox 56.0.0 (Windows 10 0.0.0): Executed 285 of 301 (skipped 16) SUCCESS (3.095 secs / 2.436 secs)