search

FirstLegoLeague / fllscoring

FLL Scoring app. See Demo:
http://firstlegoleague.github.io/fllscoring/
GNU General Public License v2.0
14 stars 19 forks source link

Fix relative urls #301

Closed poelstra closed 6 years ago

poelstra commented 6 years ago

When using fllscoring from fllproxy (https://github.com/FirstLegoLeague/fllproxy), the front-end comes up almost completely empty.

fllproxy 'inserts' a base URL with the country/region in front of the fllscoring URLs, e.g. domain.com/myregion/.... fllscoring used to work completely with these relative URLs, but this was apparently broken in relatively recent commits.

The main cause of emptiness was that the session service uses an absolute path, and the material UI icons stopped working due to a similar absolute path.

Both have been fixed, including newline and other whitespace issues (as separate commits).

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling bb717de026d00e88dc84422a4259186eba9582d8 on fix_relative_urls into on master.