search

FirstLegoLeague / fllscoring

FLL Scoring app. See Demo:
http://firstlegoleague.github.io/fllscoring/
GNU General Public License v2.0
14 stars 19 forks source link

M14 should be 25pt for completely in base #303

Open kmeesters opened 6 years ago

kmeesters commented 6 years ago

Maybe I'm missing something but shouldn't M14 give 25 pt for completely in base? In the scoring software it is is 20.

alanggreen commented 6 years ago

I checked and it is 25 points in the US-official scoresheet. Which scoresheet are you working with ? image

alanggreen commented 6 years ago

I thought I'd already responded to this but it seems I never pressed Send On my setup of the scoring software M14 gives 25 points

On Fri, Nov 24, 2017 at 6:52 PM, Kenny Meesters notifications@github.com wrote:

Maybe I'm missing something but shouldn't M14 give 25 pt for completely in base? In the scoring software it is is 20.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FirstLegoLeague/fllscoring/issues/303, or mute the thread https://github.com/notifications/unsubscribe-auth/AGccjb8icZv41Ch47gQXIn-oRee4aMEiks5s5vRggaJpZM4QqCX0 .

robvw commented 6 years ago

Both 2017_en_US.xml and 2017_nl_NL.xml give 20 points for M14. The commented-out version of M14 which ask two yes/no questions does award 25 points though.

I'll have time to fix this (and apply the changes suggested by the validator) tomorrow night. If anybody else wants to fix 20 -> 25 right now: remember to fix both versions and to regenerate all the files for which the XML is a dependency.

On 26 November 2017 at 09:42, Alan Green notifications@github.com wrote:

I thought I'd already responded to this but it seems I never pressed Send On my setup of the scoring software M14 gives 25 points

On Fri, Nov 24, 2017 at 6:52 PM, Kenny Meesters notifications@github.com wrote:

Maybe I'm missing something but shouldn't M14 give 25 pt for completely in base? In the scoring software it is is 20.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FirstLegoLeague/fllscoring/issues/303, or mute the thread https://github.com/notifications/unsubscribe- auth/AGccjb8icZv41Ch47gQXIn-oRee4aMEiks5s5vRggaJpZM4QqCX0

.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FirstLegoLeague/fllscoring/issues/303#issuecomment-346993106, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYVMyOou-imu_I3LBmEQnRMVRpuH9stks5s6SSAgaJpZM4QqCX0 .