FirstLegoLeague / launcher

A launcher program to install and launch all the micro-services of the system
GNU General Public License v3.0
9 stars 15 forks source link

Scoreboard Settings button fails to hide #178

Open tovodeverett opened 4 years ago

tovodeverett commented 4 years ago

I have had a difficult time reproducing, but we had an issue yesterday with the Settings button on the Scoreboard failing to hide when in full-screen mode. I couldn't spend too much time investigating/debugging because we had a live tournament running, I was technical support for scorekeeping, and I was coaching a team at the tournament (luckily I have a super-solid co-coach and a mature team).

I saw the issue on both a Chromebook and a PC running Chrome. It appeared to show up on both of them around the same time. I tried shift-refreshing, toggling Chrome from full-screen display to maximized, closing Chrome and re-opening, etc. I probably should have tried wiping the Chrome cache and relaunching, but I didn't think of that in the heat of battle.

It wasn't the end of the world - it's out of the way, so it just hid most of the City Shaper logo.

I'm not sure how you detect full-screen, or if perhaps you could add a fail-safe setting to the Settings page that says "hide Settings button" - ideally this button would toggle with Full Screen mode, but then it would provide an override if the Full Screen detection logic stops working.

This feedback is based on 2019.1.2.514.