FirstPersonKSP / RasterPropMonitor

Plugin for Kerbal Space Program
https://forum.kerbalspaceprogram.com/index.php?/topic/190737-18x-rasterpropmonitor-adopted/&tab=comments#comment-3723047
Other
24 stars 13 forks source link

Controls still work when a probe loses signal #124

Open Fedex75 opened 6 months ago

Fedex75 commented 6 months ago

When a probe loses CommNet connection the monitors and controls still work.

KSP.log

Steps to reproduce the behavior:

  1. Launch a probe
  2. The probe loses signal
  3. Go into probe control room
  4. Monitors still display information and controls still work

Expected behaviour: The monitors should turn off and controls shouldn't work, like when the probe runs out of electric charge.

image Here we can see that the probe has no connection but the monitors are still working.

Fedex75 commented 6 months ago

Ok after looking at RasterPropMonitor.cs i think i understand it's more complex. So in order for the computer to disable the monitors when it loses signal, they would have to be configured with "needsCommConnection = true". The ALCORMFDs don't set that field so it's left false. But we can't change that directly on their cfg files because then all MFDs would require signal, even those inside command modules.

So the question then becomes, is there a way to change a field for an individual MFD?

JonnyOThan commented 6 months ago

Yeah good question...My hunch is that the solution here would be to have some variable on the RasterPropMonitorComputer (the partmodule that lives on the probe part) that controls the behavior. Then all probes can be set up so that they require a signal and command pods don't.

Fedex75 commented 6 months ago

Yeah that sounds good. On my local install i created new MFD props with their needsCommConnection always set to true and used those on the mission control cfg but that solution sucks.

By the way, this is unrelated but would it be possible to show the navigation marker on the MFD's navball? I mean things like this: image

Since it already shows markers for prograde and things like that i figure it shouldn't be too hard right? It doesn't necessarily have to show the specific icons like the thermometer, just any symbol would be ok.