search

Firstyear / obs-service-cargo

OBS Source Service and utilities for Rust software packaging
Mozilla Public License 2.0
16 stars 9 forks source link

Old files left in vendor directory #16

Closed etam closed 3 years ago

etam commented 3 years ago

I was updating helvum package (https://build.opensuse.org/package/show/multimedia:apps/helvum). According to wiki (https://en.opensuse.org/Packaging_Rust_Software#Updating_your_Package) I was supposed to just run osc service runall to get everything updated.

What I got instead was this: https://github.com/EmbarkStudios/cfg-expr/issues/34 A package cfg-expr had an update, where files src/expr/mod.rs and src/targets/mod.rs were present in earlier version, but were removed in newer version. After running the service those files were still present in vendor.tar.xz.

I had to delete vendor.tar.xz manually and run the service again, to get a working build.

Firstyear commented 3 years ago

Which version of obs-service-cargo_vendor were you using?

etam commented 3 years ago

I'm on Tumbleweed

> rpm -q obs-service-cargo_vendor
obs-service-cargo_vendor-0.4.3~git0.afec7bc-1.1.noarch
Firstyear commented 3 years ago

Older versions of obs cargo_vendor didn't clean up properly, but the latest one does, so I think this is already resolved. I've just done an obs checkout and ran service ra 3 times in a row, and they all passed, and vendor isn't left over in the dir. Sorry about the issues.