search

Firstyear / obs-service-cargo

OBS Source Service and utilities for Rust software packaging
Mozilla Public License 2.0
16 stars 9 forks source link

missing Requires: python(abi) >= 3.8 #19

Closed olafhering closed 2 years ago

olafhering commented 2 years ago

obs-service-cargo_vendor-0.4.3~3 requires python 3.8+, but this requirement is not specified in the spec file. As a result this package fails to run in a SLE15-SP4 environment.

INFO:obs-service-cargo_vendor:Running OBS Source Service: obs-service-cargo_vendor
Traceback (most recent call last):
  File "/usr/lib/obs/service/cargo_vendor", line 213, in <module>
    main()
  File "/usr/lib/obs/service/cargo_vendor", line 208, in main
    if not do_cargo_vendor(args.srcdir, args.srctar, args.outdir, update, args.compression, args.tag):
  File "/usr/lib/obs/service/cargo_vendor", line 138, in do_cargo_vendor
    lsrcdir = shutil.copytree(srcdir, dirpath, dirs_exist_ok=True)
TypeError: copytree() got an unexpected keyword argument 'dirs_exist_ok'
Firstyear commented 2 years ago

@olafhering No problem I can fix that in the spec file.

Firstyear commented 2 years ago

https://build.opensuse.org/request/show/980940

olafhering commented 2 years ago

This is a runtime requires AFAICS.

Firstyear commented 2 years ago

BuildRequires implies the Requires IIRC

olafhering commented 2 years ago

Only if the resulting scripts get a fixed path to the interpreter. This may not be the case as of today, I see env python3 in /usr/lib/obs/service/cargo_vendor

Firstyear commented 2 years ago

Okay, submitted new updates with Requires as well.