search

Firstyear / obs-service-cargo

OBS Source Service and utilities for Rust software packaging
Mozilla Public License 2.0
16 stars 9 forks source link

globbed srctar and srcdir? #24

Closed mcepl closed 1 year ago

mcepl commented 1 year ago

With all other services which are included in _service files it is usually Write-Once-and-Forget type of action. It seems to me that in the case of cargo_vendor service the only problem is the need to put full name of either srcdir or srctar, when in most cases I have found them I have versioned names of them (e.g., external-editor-revived-*.tar.gz for https://github.com/Frederick888/external-editor-revived).

Would it be possible to have globbed value accept as well, so that I could write for example?

<services>
  <service name="cargo_vendor" mode="disabled">
     <param name="srctar">external-editor-revived-*.tar.gz</param>
     <param name="compression">xz</param>
     <param name="update">true</param>
  </service>
  <service name="cargo_audit" mode="disabled">
     <param name="srctar">external-editor-revived-*.tar.gz</param>
  </service>
</services>
Firstyear commented 1 year ago

I don't see a reason why not? I don't have time this week, but maybe next I can have a look. Or if you want it sooner, I'm always open to PR's.

Firstyear commented 1 year ago

Fixed in master

mcepl commented 1 year ago

The same should go to obs-service-cargo-audit.

mcepl commented 1 year ago

@Firstyear https://build.opensuse.org/request/show/1067601