Missing bz2 compression

[paddg]

This is a feature request.

Since some projects ship their source code bz2 compressed, it would be nice if obs-service-cargo_vendor support this compression in addition to zst, gz and xz.

[Firstyear]

We should probably make this decompress only, since bz2 has worse performance and ratios compared to zstd for our vendoring.

[paddg]

Yes, but it is not this worse compared to xz and gzip. It would be fine for me if I could use the source code tar.bz2 out-of-the-box. I think it doesn't matter how the vendor.tar is then compressed.

[uncomfyhalomacro]

This is a feature request.

Since some projects ship their source code bz2 compressed, it would be nice if obs-service-cargo_vendor support this compression in addition to zst, gz and xz.

Closed as completed on commit ca11f4bd58563e3ed9f4ad45cd68be8649823222

[paddg]

Thanks!!

Unfortunately it does not work on my tar.bz2 archive:

$ /usr/lib/obs/service/cargo_vendor --src pdns-recursor-5.0.0-beta1.tar.bz2 --cargotoml settings/rust/Cargo.toml --outdir .
2023-12-06T08:55:25.646063Z  INFO cargo_vendor: 🎢 Starting OBS Service Cargo Vendor.
2023-12-06T08:55:25.646077Z  WARN cargo_vendor: ⚠️  Cargo Vendor has been rewritten in rust!

This rewrite introduces some small changes to how vendoring functions for your package.

* cargo_config is no longer created - it's part of the vendor.tar now
    * You can safely remove lines related to cargo_config from your spec file

* multiple cargotoml files can be specified and share a single vendor.tar
    * If multiple cargo.toml files are present update does not work. This is a known
      limitation of the process

* cargo_audit is now part of cargo_vendor, meaning you don't have to configure it separately

2023-12-06T08:55:25.646148Z  INFO obs_service_cargo::utils: 🍿 Vendoring for src 'pdns-recursor-5.0.0-beta1.tar.bz2'
2023-12-06T08:55:25.646165Z ERROR obs_service_cargo::cli: err=UnsupportedFormat { ext: "application/x-bzip2" }
2023-12-06T08:55:25.646201Z ERROR cargo_vendor: kind: cargo vendor process failed
reason: Unsupported archive format application/x-bzip2
Error: kind: cargo vendor process failed
reason: Unsupported archive format application/x-bzip2

$ zypper info obs-service-cargo

Information for package obs-service-cargo:
------------------------------------------
Repository     : Rust (15.4)
Name           : obs-service-cargo
Version        : 0.8.18-lp154.15.1
Arch           : x86_64
Vendor         : obs://build.opensuse.org/devel:languages:rust
Support Level  : unknown
Installed Size : 4,2 MiB
Installed      : Yes
Status         : up-to-date
Source package : obs-service-cargo-0.8.18-lp154.15.1.src
Upstream URL   : https://github.com/openSUSE/obs-service-cargo_vendor
Summary        : OBS Source Service and utilities for Rust software packaging
Description    : 
    This is an OBS Source Service that contains two main utilities:
    - OBS Service Cargo Vendor
    - OBS Service Cargo Audit

    This vendors and audits dependencies for packaging Rust software.

Am I doing something wrong?

[uncomfyhalomacro]

odd. @paddg can you give me a sample bz file i can test?

[uncomfyhalomacro]

nvm. i did something wrong

[paddg]

odd. @paddg can you give me a sample bz file i can test?

https://downloads.powerdns.com/releases/pdns-recursor-5.0.0-rc1.tar.bz2

nvm. i did something wrong

np

[uncomfyhalomacro]

odd. @paddg can you give me a sample bz file i can test?

https://downloads.powerdns.com/releases/pdns-recursor-5.0.0-rc1.tar.bz2

nvm. i did something wrong

np

thanks. i already updated a release. going to test your file locally now if it worked

[uncomfyhalomacro]

@paddg worked. going to add this to the run tests script. thanks for reporting!

[paddg]

@uncomfyhalomacro, confirmed, thanks a lot!!