search

Firstyear / obs-service-cargo

OBS Source Service and utilities for Rust software packaging
Mozilla Public License 2.0
15 stars 9 forks source link

Add experimental vendor_filterer support #77

Closed msirringhaus closed 4 months ago

msirringhaus commented 4 months ago

Build fails because of #76

uncomfyhalomacro commented 4 months ago

Hello. As much as I would like to tackle this, I am not sure if the filter still works despite our efforts at https://github.com/openSUSE/obs-service-cargo_vendor/pull/48. Some odd behaviors are described in that PR that is why we didn't pursue this.

If you really want to tackle this, please ensure to provide test cases e.g. rust software that exists for Windows, MacOS, and Linux. As that will be a starting point :)

uncomfyhalomacro commented 4 months ago

Build fails because of #76

This is now fixed. Please update your branch from upstream changes.

msirringhaus commented 4 months ago

Rebased to fix the build.

Regarding testing: I've tried it with cross-platform crates like ripgrep, eza, git-delta, and also with more complicated (and for the most part also cross-platform) crates like zellij, fractal, typst, alacritty, and helix. All of them build well (including tests). The only exception I encountered that does not build fine with the filtered vendor-tarball is kanidm. I haven't yet understood exactly what is happening there, but that is the reason I added it as an experimental opt-in flag for now.

msirringhaus commented 4 months ago

Oh, and fwiw: HEAD of kanidm works fine, too. But v1.1.0-rc.16 fails.

Firstyear commented 4 months ago

I think that's fine provided we don't need to re-vendor kanidm for now. Worst case I can vendor that manually in the shortterm.