Add new fish independently

[yashsnehalshah]

Summary

Enable functionality that helps to add new fish to the system, independent of other modules. Story created as per suggestion from Professor.

Acceptance Criteria

1. A user can add a fish from the Fish page.
2. A fish added from the Fish page is not directly associated to a previously created Trip.

[Fish360]

Implementation Idea

• The data model we have has Fish associated with a Trip.
• One idea is to create an default Trip.
• Each Angler has this default trip.
• A Fish that is added from the Fish page will be associated with this default trip.
• This default trip does not need to be visible to the Angler. It's just a container.

Just an idea. :-)

[Fish360]

Related User Story

Once we have this working, a follow up user story would be to allow an Angler to associate a Fish to a Trip. See: #33

A fish can only be associated to one trip a time.

[Fish360]

@yashsnehalshah, @jannunzi

Thank you for adding this! I updated and added some comments.

[yashsnehalshah]

Thanks for the implementation suggestion @Fish360

Will work on it.

Today professor @jannunzi showed me how to perform the required URL change and i did follow his instructions and created a new APK on my local machine. I installed the APK on my android mobile device. While testing, i found out that the logout option seems buggy. The app goes blank when the logout button is clicked and then just hangs there. I had to force close the app. I am not sure if this is really an app problem or a problem with my device. Otherwise the APK worked fine on my device. I will rebuild-it again with updated mobile desktop icon name.

Just one small question, will you be assigning us tasks for each Sprint or should we self-assign them? And when does the Sprint 0 end?

Regards,

Yash

[Fish360]

Just one small question, will you be assigning us tasks for each Sprint or should we self-assign them? And when does the Sprint 0 end?

• Each sprint is due at the end of each month.
• I try to plan n + 2 sprints at a time. I.e., up to two sprints ahead of the current sprint.
• I will assign issues based on areas of expertise and functional areas in the current and future sprints.
• If you complete your assignment, then pull in an issue from the next sprint.
  • If nothing is assigned to you, then assign something to yourself that you would like to work on.
  • Just change the "Milestone" field accordingly.
• With the n + 2 sprints and a growing backlog, there is always something to work on. :-)
• There some crazy cool features that are not even on the back log yet!

@yashsnehalshah

[yashsnehalshah]

Got it. Thank you.

[yashsnehalshah]

Julio @Fish360 ,

The current functionality that allows users to add fish to a trip, asks for many fields such as caught date, spot, species, gear, size, tide info etc. As i understand, the only fields that should be presented to angler when he independently adds a fish(new functionality) should be species and notes. Is this correct? The user can then fill up the misc details when he actually catches it at a later stage. I am starting to design the functionality so just wanted to confirm.

[Fish360]

@yashsnehalshah

For this version, let's the the following:

1. Display all of the fields that are available when an Angler adds a new Fish to a Trip.

2. The "Caught Date/Time" fields should default to the current date and time.

Once we have the new web client up, I will test it and create new user story to refine this functionality (as needed).

Aside: Each angler will add different levels of detail, depending on what's important to him or her. Some of the fields will be auto-populated with services (e.g., tide, weather, etc). We will revisit the data services in Sprint 1, 2, and 3.

[yashsnehalshah]

Hey Julio @Fish360 ,

I tried to build the "add new fish independently" function. Here are the screens. It works fine except for the caught time field, where i am not able to show the current time in the required HH:MM AM/PM format. Will work on that. The caught date field defaults to the current date.

[Fish360]

Cool!

Keep up the great work!!

@yashsnehalshah

[yashsnehalshah]

Sure:-)

[Fish360]

Meeting Minutes

Use Case

1. Login
2. Go to Fish page.
3. Click the "+"
4. [SYSTEM: default trip is created behind the scenes. This is done only when the first non-trip fish is added.]
5. Add fish screen is displayed.
6. User enters data.
7. Saves

Action Items

@jannunzi please review pull request and code.

[Fish360]

Failed re-test. :-(

@jannunzi, did @yashsnehalshah's the pull request get merged and deployed?

[yashsnehalshah]

@Fish360 Hi Julio,

The request has been merged. But it has not been deployed to heroku yet. Did you git pull and then run the project on your local machine? If its still giving errors, I can look into it.

[yashsnehalshah]

@Fish360

As an update, me and Ankita are working on creating a "developer guide" kind of document as suggested by professor. That would help the next set of developers joining the Fish360 family to have a good starting reference to begin with the coding process. Hope this sounds good.

[Fish360]

@yashsnehalshah

A developer guide sounds like a brilliant idea!

Transfer knowledge between teams a priceless skill!!!! ;-)

[yashsnehalshah]

That's what Professor Jose said too :smiley: )

[Fish360]

@jannunzi,

Can you follow up on this? I think we still have a deployment issue. I the new functionality is not available. :-(

[Fish360]

@jannunzi,

1. Passed re-test on test environment (https://fish360-journal-test.herokuapp.com).
2. Please deploy this bug fix to the production environment (https://fish360.herokuapp.com).