search

Fish360 / Journal

Fish360 Journal
0 stars 0 forks source link

Add Weather to Spot #38

Open Fish360 opened 6 years ago

Fish360 commented 6 years ago

Summary

When an Angler views a spot, the weather is displayed based on the current day and the spot's LAT and LONG.

patelankita commented 6 years ago

Hey Julio @Fish360, Can I start working on this issue, while you assign us the tasks for Sprint 2?

Fish360 commented 6 years ago

@patelankita

Ankita,

Yes.

Assigned.

Fish360 commented 6 years ago

@jannunzi,

We need a way to decouple the weather/tide service such that the code reads in the API information from a file.

This will allow different installations of the Fish360 Journal to specify what tide/weather API to use.

Has this already been done or do we need a new ticket?

patelankita commented 6 years ago

@Fish360 Julio, I have a question. The spot doesn't have a field for the Date. And for the weather to be displayed, we need the current date and longitude and latitude. So should I first add the date field to the spot? Please correct me if I am understanding it wrong.

Fish360 commented 6 years ago

@patelankita

Ankita,

You are correct!

Let's add a Date field to the Weather region on the spot.

The default value of the Date field is the current day.

patelankita commented 6 years ago

@Fish360 Perfect i have implemented it with the default value as the current day. I am getting a small bug currently, but will resolve it and create a pull request by EOD.

patelankita commented 6 years ago

@Fish360 Julio, since morning I am not able to access the weather API. It gives the following error on the console.

screen shot 2018-04-10 at 2 12 18 pm

On opening the link in browser it shows - "API key has been disabled".

screen shot 2018-04-10 at 2 12 07 pm

The functionality has been implemented, but am not able to put up the screen shots because of the API error. I will talk to the professor as well about this. Please let me know if you know of any way to resolve this.

Thanks, Ankita

Fish360 commented 6 years ago

@patelankita

Ankita,

There is an issue with the API provider. I am in communication with their tech support. It will be resolved soon'ish.

patelankita commented 6 years ago

@Fish360 Thank you Julio. I will post the screen shots of the added funcitonality as soon as the API starts working.

Fish360 commented 6 years ago

@patelankita

The issue with the Weather/Tide API service has been resolved. The API should be returning data now, or very soon.

patelankita commented 6 years ago

@Fish360 Julio, I am still getting the same error. API key disabled.

Fish360 commented 6 years ago

@patelankita

Ankita,

:-(

I will follow up again with the service provider.

Fish360 commented 6 years ago

Test Result

Failed testing.
Renewing the API license did not resolve the issue. Requires investigation.