Open Fish360 opened 6 years ago
@Fish360
Hi Julio, I have a question regarding this issue. How do we plan to use this new field that will be added to spot? Right now, we have a drop-down list of spots that we see when we wither add/edit a trip or add/edit a fish. Instead, do we want to see a drop-down list of spot groups in which clicking on any group entry shows a list of spot for that group? That may help angler to search a spot efficiently from the drop-down list?
I am just trying to understand how this functionality will help us solve a problem at an upper-level.
Can you please guide me as to what is the final aim of this new feature?
Thanks.
Added the "group" feature for "new spot" module. Will also do that for the "edit spot" module. New groups get reflected in the drop-down.
User sees if the group he needs is present in the drop-down. If yes, he selects the group of his choice. Else, he presses the "+" button to add a new group. This lands him to the "new spot group" page. Here user enters the new group name. Clicks the check sign to save(designed so as to be consistent with the UI of rest of the features). Then the user is redirected back to the "new spot" page where he can now see the newly added group in the drop-down. He selects the group and subsequently saves the new spot. I will implement similar stuff in "edit spot" module where the user can edit the group too from the drop-down(If this seems correct).
@yashsnehalshah
Yash,
The screen shots and the functional behavior you described is correct.
Aside:
@Fish360
Awesome, thanks for the elaborate description and those wireframes, Julio. Now i understand how the group feature is aimed to be used :)
@Fish360
Hi Julio, I have implemented the functionality in "edit spot" page as well. Here are the screens:
So when a user opens the edit spot page, he/she sees the current group(that the user selected while creating the spot) from the drop-down in the field. Then he can either edit that by selecting some other group from the drop-down or add a new group using "+" sign if he wants to create a new one. After making the choice, the user clicks on the check sign to update the spot. I will create a branch and pull request for this issue. Meanwhile, can you assign me some more issues to work on? Thanks.
@yashsnehalshah
Yash,
Great work!
I will review all of the tickets and assign you some additional ones.
@Fish360
Sure. Thanks Julio!
@Fish360 Hi Julio,
I have remodeled the "add/edit spot group" feature to reduce the number of extra pages and controllers.
The add new spot page:
User sees if the spot groups he/she needs is present in the dropdown. If yes, user selects it. If no, user clicks on the "+" button which will unhide a div as below:
Now user clicks the "check" button to save the new group. He can now see that group in the dropdown and select it and save.
Now to edit the group, user chooses the edit spot option and here he sees his previous selections, which can be edited by using dropdown or clicking on the "pencil" button which will unhide a div as shown above.
Hope this looks better now.
This feature works exactly as expected. The reduced number of clicks is a big win! Great work @yashsnehalshah
The bug that I was seeing in not with this user story. It's a data issue. The feature works great on new spots.
@jannunzi,
@Fish360
Thank you Julio. Glad that I got an opportunity to build some useful feature!
Summary
An angler can have hundreds to thousands of spots. Spot Groups is a way for the angler to create a group and then characterize his or her respective spots.
Worfklow
Add/Edit Spot
Add Group