search

Fishrock123 / bob

🚰 binary data "streams+" via data producers, data consumers, and pull flow.
MIT License
79 stars 8 forks source link

references: add offset to pull #25

Closed Fishrock123 closed 7 months ago

Fishrock123 commented 5 years ago

Refs: https://github.com/Fishrock123/bob/issues/23

Raynos commented 5 years ago

If you add an offset to pull() it makes sense to also add an offset to next()

Fishrock123 commented 5 years ago

@Raynos You mean to note where that particular read was done from?

Raynos commented 5 years ago

Correct, to note at which offset the n bytes where read into the buffer.

But this raises a good question, what does offset on pull() mean ? the offset to read into in the buffer or the offset to read from in whatever the source is ( like an offset in a file on disk ).

Fishrock123 commented 5 years ago

It was supposed to be source read location. I am still not really sure this fits well into the stream abstraction...

Raynos commented 7 months ago

Closing out due to lack of activity.