search

Fishrock123 / bob

🚰 binary data "streams+" via data producers, data consumers, and pull flow.
MIT License
79 stars 8 forks source link

test: fixing the wrong relative path #51

Closed antsmartian closed 5 years ago

antsmartian commented 5 years ago

The old test's looks like have wrong path to the addons. This will fix it.

ping @Fishrock123

Fishrock123 commented 5 years ago

Do the addons even compile? I think most of them need to be changed / rewritten anyways.

Plus I never really solved https://github.com/Fishrock123/bob/issues/29

antsmartian commented 5 years ago

Hmmm, yeah it does compile. I could run the file: https://github.com/Fishrock123/bob/blob/master/tests/old/file-to-file-test-c++-double.js (after getting the addon's compiled), I do see the code running:

bound c++ sink!
bound c++ source!
C++ -> C++ pull!
C++ -> C++ next!
C++ -> C++ pull!
C++ -> C++ next!
C++ -> C++ pull!
C++ -> C++ next!
done

Edit: I did went to each directory to get the addons compiled. node-gyp configure and node-gyp build ran without any issues.

Fishrock123 commented 5 years ago

Thanks. Landed as https://github.com/Fishrock123/bob/commit/c307db401b2a29f451e7d2631c52709b7e1c8d3b